fix: suppress completed request cancellation leak by MukundaKatta · Pull Request #2611 · modelcontextprotocol/python-sdk

MukundaKatta · 2026-05-15T20:05:51Z

Summary

return the underlying CancelScope.exit suppression result from RequestResponder.exit
swallow a late cancellation from an already-cancelled/completed responder so cancelled requests do not tear down sibling tasks
add regressions for completed responder cancellations

Fixes #2610.

uv run pytest tests/shared/test_session.py -q -k "request_responder or request_cancellation"
uv run pytest tests/server/test_cancel_handling.py tests/shared/test_session.py -q
uv run ruff check src/mcp/shared/session.py tests/shared/test_session.py
uv run ruff format --check src/mcp/shared/session.py tests/shared/test_session.py
uv run pyright src/mcp/shared/session.py tests/shared/test_session.py

maxisbey · 2026-05-18T17:05:24Z

Closing as a duplicate of #2624, which the #2610 reporter has been validating. Thanks for the contribution.

MukundaKatta force-pushed the codex/request-responder-cancel-leak branch from e7e92b3 to e199eef Compare May 15, 2026 20:10

fix: suppress completed request cancellation leak

274446f

MukundaKatta force-pushed the codex/request-responder-cancel-leak branch from e199eef to 274446f Compare May 15, 2026 20:13

This comment was marked as abuse.

Sign in to view

maxisbey closed this May 18, 2026